Skip to content

test: Deflake webhook dispatches iterate test by polling for the dispatch - #1047

Merged
vdusek merged 1 commit into
masterfrom
test/deflake-webhook-dispatches-iterate
Sep 3, 2026
Merged

test: Deflake webhook dispatches iterate test by polling for the dispatch#1047
vdusek merged 1 commit into
masterfrom
test/deflake-webhook-dispatches-iterate

Conversation

@vdusek

@vdusek vdusek commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

test_webhook_dispatches_iterate drained dispatches().iterate() once, right after webhook_client.test(). The dispatch is recorded asynchronously, so under load the listing can still be empty (total=0) and the test fails with assert 0 >= 1 (failed run). The sibling test_webhook_dispatches failed the same way twice before and got a poll in #1004; the iterate variant did not.

The test now keeps the dispatch returned by test() and drains the iterator via collect_iterate_until_present until that ID shows up, then asserts membership, which is stricter than the previous "at least one dispatch" check.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Sep 2, 2026
@vdusek vdusek self-assigned this Sep 2, 2026
@github-actions github-actions Bot added this to the 148th sprint - Tooling team milestone Sep 2, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.27%. Comparing base (779b17f) to head (90c4b9c).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1047   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          59       59           
  Lines        5502     5502           
=======================================
  Hits         5242     5242           
  Misses        260      260           
Flag Coverage Δ
integration 92.22% <ø> (-0.11%) ⬇️
unit 87.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek requested a review from Pijukatel September 2, 2026 14:28
@vdusek
vdusek marked this pull request as ready for review September 2, 2026 14:28
@vdusek
vdusek merged commit f739c77 into master Sep 3, 2026
30 checks passed
@vdusek
vdusek deleted the test/deflake-webhook-dispatches-iterate branch September 3, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants