Skip to content

test: Deflake adaptive crawler timeout test against slow CI browser navigation #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vdusek wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

test: Deflake adaptive crawler timeout test against slow CI browser navigation #2207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
863b025
fix: Add navigation_timeout to _PlaywrightCrawlerAdditionalOptions
vdusek Sep 1, 2026
c7df284
test: Deflake adaptive crawler timeout test against slow CI browser n…
vdusek Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/crawlee/crawlers/_playwright/_playwright_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,9 @@ class _PlaywrightCrawlerAdditionalOptions(TypedDict):
headless: NotRequired[bool]
"""Whether to run the browser in headless mode. This option should not be used if `browser_pool` is provided."""

navigation_timeout: NotRequired[timedelta]
"""Timeout for navigation (the process between opening a Playwright page and calling the request handler)."""


class PlaywrightCrawlerOptions(
_PlaywrightCrawlerAdditionalOptions,
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/crawlers/_adaptive_playwright/test_adaptive_playwright_crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,11 @@ async def test_adaptive_playwright_crawler_timeout_in_sub_crawler(test_urls: lis
max_request_retries=0,
rendering_type_predictor=static_only_predictor_no_detection,
request_handler_timeout=request_handler_timeout,
# The fallback browser request navigates under its own `navigation_timeout` budget, separate from
# the request handler timeout relaxed in the handler below. Give it the same generous ceiling:
# with `max_request_retries=0`, a single navigation slower than the default budget on a loaded CI
# runner would fail the only attempt before the handler ever runs.
playwright_crawler_specific_kwargs={'navigation_timeout': timedelta(seconds=120)},
)
mocked_static_handler = Mock(name='static_handler')
mocked_browser_handler = Mock(name='browser_handler')
Expand Down
Loading