Skip to content

feat:add SSR start command support for sites#2990

Open
HarshMN2345 wants to merge 6 commits intomainfrom
fix-ssr-start-command-sites
Open

feat:add SSR start command support for sites#2990
HarshMN2345 wants to merge 6 commits intomainfrom
fix-ssr-start-command-sites

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

What does this PR do?

image

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 22, 2026

Greptile Summary

This PR adds SSR startCommand support across the sites creation and settings surfaces: a shared FrameworkAdapterWithStartCommand type is extracted to sites.ts, uploader.uploadSiteDeployment accepts and forwards the new field, and all settings update components now round-trip startCommand so it is not silently dropped on unrelated saves. The previous gap (manual-upload path not forwarding startCommand to the uploader) is resolved in this revision.

Confidence Score: 5/5

Safe to merge; the single P2 finding is a minor UX inconsistency with no data-loss risk.

All changed paths correctly thread startCommand through creation, deployment, and settings flows. The only finding is a P2 UI inconsistency in the one-click deploy page where the Start command field is shown for static adapters, unlike other surfaces. No data is corrupted and the field value falls back to undefined when empty.

src/routes/(console)/project-[region]-[project]/sites/create-site/deploy/+page.svelte — Start command field lacks an SSR-adapter guard.

Important Files Changed

Filename Overview
src/lib/stores/sites.ts Adds shared FrameworkAdapterWithStartCommand type extending Models.FrameworkAdapter with an optional startCommand field — good extraction to a shared location.
src/lib/stores/uploader.ts Adds startCommand parameter to uploadSiteDeployment, correctly threads it into the createDeployment payload.
src/routes/(console)/project-[region]-[project]/sites/create-site/deploy/+page.svelte Adds startCommand state and URL param handling, but the Start command input is rendered unconditionally in the Build configuration fieldset — inconsistent with other UIs that guard it behind an SSR adapter check.
src/routes/(console)/project-[region]-[project]/sites/create-site/configuration.svelte Correctly gates the Start command field behind {#if adapterData?.key === 'ssr'} and refactors framework-change detection to avoid unnecessary resets.
src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte Correctly adds startCommand to both the sites.create call and the uploader.uploadSiteDeployment call (addressing the gap noted in the previous review).
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte Properly adds startCommand state, reset support, and SSR-guarded input field; refactors adapter-change detection to prevent double-reset on initialization.
src/routes/(console)/project-[region]-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte Adds startCommand to adapter initialization, sites.create call, and passes it through bind:startCommand on the Configuration component.
src/routes/(public)/sites/deploy/+page.svelte Correctly forwards start URL query param to the downstream deploy URL.

Reviews (6): Last reviewed commit: "fix sites settings start command sync" | Re-trigger Greptile

@HarshMN2345 HarshMN2345 requested a review from Meldiron April 22, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant