fix: show real OAuth error on failure relay page#3140
Merged
Conversation
When project is missing but an error query param is present, display the actual OAuth failure instead of the misleading "Missing redirect URL" message.
2 tasks
Contributor
Greptile SummaryUpdates the OAuth failure relay to display an available OAuth error instead of missing-redirect guidance.
Confidence Score: 5/5The PR appears safe to merge. No blocking failures remain. Important Files Changed
Reviews (2): Last reviewed commit: "fix: pin postcss and brace-expansion to ..." | Re-trigger Greptile |
Co-authored-by: Cursor <cursoragent@cursor.com>
HarshMN2345
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The OAuth failure relay page previously treated a missing
projectquery param as "Missing redirect URL", even when anerrorpayload was present (e.g.user_already_exists). This shows the real error message/type whenerroris present, and only falls back to the missing-redirect copy when neitherprojectnor a parseable error exists.Test Plan
/console/auth/oauth2/failure?error=%7B%22message%22%3A%22User%20already%20exists%22%2C%22type%22%3A%22user_already_exists%22%2C%22code%22%3A409%7Dwithoutproject./console/auth/oauth2/failurewith no params and confirm the existing "Missing redirect URL" copy still appears.projectpresent, confirm the deep-link redirect behavior is unchanged.Related PRs and Issues