Repository navigation
test: move SSRF fixtures to httpbin.dev - #27
Closed
ChiragAgg5k wants to merge 1 commit into
Closed
ChiragAgg5k wants to merge 1 commit into
ChiragAgg5k wants to merge 1 commit into
Conversation
httpbin.org now refuses redirects to internal addresses and serves /base64 as text/plain with nosniff, so the browser never attempted the private hop and the four redirect and script tests captured a 200 instead of a 403.
🟢 Tier S · Ready to merge
The SSRF end-to-end fixtures now use httpbin.dev for open redirects and HTML script navigation. The script-page helper URL-encodes the HTML and quotes the navigation target with backticks.
📂 Walkthrough · 1
Reviewed |
![hansi-codes[bot]](https://avatars.githubusercontent.com/in/5046327?s=60&v=4){kind=small}
Docker Image Stats
Screenshot benchmark: Average of 3 runs on https://appwrite.io |
Member
Author
|
Included in #26, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Four SSRF e2e tests fail on
mainand on0.3.10alike. The cause isn't the guard: httpbin.org changed./redirect-to?url=http://127.0.0.1…/base64/<script>…text/plain+nosniffWhat
https://httpbin.dev/redirect-to?url=(still returns a 302 to internal targets)https://httpbin.dev/response-headers?Content-Type=text/html&page=<script>…(the parameter is echoed into a body served astext/html). The target is quoted with backticks because JSON escapes"Verified
BASE_URL=… bun test tests/e2e/ssrf.test.tsagainstappwrite/browser:0.3.10: before 2 pass / 4 fail, after 6 pass / 0 fail (two runs).