Cache Recovery and Completion Tests#86
Open
DanielDango wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds integration coverage for the new configurable hierarchical cache (local + Redis) by spinning up Redis via Testcontainers and validating cache recovery/completion scenarios, plus a small fix to .env loading behavior.
Changes:
- Add
CacheRecoveryIntegrationTestto exercise Local → Redis backfill and Redis → Local recovery/completion flows. - Adjust
Environment.overwrite(Path)to load dotenv via directory + filename. - Add Testcontainers dependencies and introduce a second WARC config that writes cache output to a different directory.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/resources/warc/config-without-cache.json | Adds an alternative evaluation config targeting a separate cache directory for recovery tests. |
| src/test/resources/warc/cache/SimpleClassifier_gpt-4o-mini-2024-07-18_133742243.json | Updates a cached fixture used by the WARC evaluation tests. |
| src/test/java/edu/kit/kastel/sdq/lissa/ratlr/cache/CacheRecoveryIntegrationTest.java | New Redis-backed integration tests validating hierarchical cache recovery/completion/preservation. |
| src/main/java/edu/kit/kastel/sdq/lissa/ratlr/utils/Environment.java | Changes dotenv loading to use directory + filename (but needs a null-parent guard). |
| pom.xml | Adds Testcontainers JUnit integration deps (currently with mismatched versions). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
dfuchss
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #75
@dfuchss this can be merged into #75 if the tests should remain part of the project.
This PR introduces integration tests for the configurable multi-layered caches.
Using a testcontainer a Redis instance is spun up to verify various expected behaviours of the new hierarchical cache when combining the existing local and Redis cache implementations.