Repository navigation
fix(testing): match replay state to the service - #795
Open
zhongkechen wants to merge 1 commit into
Open
zhongkechen wants to merge 1 commit into
zhongkechen wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
7 of 11 tasks
zhongkechen
added this pull request to stack #800
October 21, 2026 19:32
zhongkechen
removed this pull request from stack #800
October 22, 2026 17:25
zhongkechen
added this pull request to stack #809
October 22, 2026 17:25
zhongkechen
added a commit
that referenced
this pull request
Oct 22, 2026
Merge the updated testing layer from PR #795. Register cases 21-26 through the shared factory selector and instrument fresh plugin instances in conformance tests. Preserve the existing requirement and workflow pins.
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 22, 2026 18:00 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 22, 2026 19:38 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 22, 2026 20:11 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 22, 2026 20:48 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 22, 2026 22:35 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
force-pushed
the
fix/python-testing-replay-state-20261021
branch
from
October 22, 2026 23:25
7992a95 to
ed0dd92
Compare
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 22, 2026 23:26 — with
GitHub Actions
Error
This comment has been minimized.
This comment has been minimized.
zhongkechen
force-pushed
the
fix/python-testing-replay-state-20261021
branch
from
October 23, 2026 00:04
ed0dd92 to
1f2768b
Compare
zhongkechen
had a problem deploying
to
ai-pr-review-runtime
October 23, 2026 00:05 — with
GitHub Actions
Error
Contributor
Codex AI reviewNo actionable findings in the PR changes. Review was limited to static inspection; tests were not executed, leaving residual runtime, concurrency, and service-parity risk. Reviewed commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local testing service exposed descendants that the service prunes, and successful input-only resumes could receive the same callback updates again. This change aligns replay-state visibility and input acknowledgment with the service while retaining complete raw operation/history inspection.
Invocation input and GetDurableExecutionState omit descendants of completed CONTEXT ancestors unless those ancestors retain
ReplayChildren. The ancestry walk handles ordering, STARTED intermediates, orphans and cycles. Valid handler responses acknowledge only the sequence captured in that invocation's input, including checkpoint-free PENDING; failed delivery and newer updates remain pending. Callback state keeps absent runtime error details distinct from present empty history payloads.Stack and coverage
main → #758 → #795 → #796
This layer contains the testing fixes and dependent integration/installed-compatibility tests. It installs the built testing wheel alongside Core/OTel and retains the workflow branch filters needed by #795/#796 while stacked. #758 uses the published testing library and
main-only workflow filters.Tests use Core 3 / OTel 2 factories and fresh plugins per invocation. Generic hooks may repeat a natural completion observation within one invocation; observer assertions still reject cross-invocation redelivery and verify each payload. OTel export counts, parent identities, statuses, replay barriers and saved-step counts remain exact.
Validation and limits
The final stacked artifacts pass 906 installed OTel tests, 16 installed lifecycle/callback cases and four released-OTel registration rejection cases. The base #758 artifacts independently pass 875 OTel tests against published testing 1.3.0. An additional 112 workflow/conformance-package checks pass, along with types, lint, formatting, builds and commit-message validation. Installed sources and wheel hashes are verified. GitHub CI runs separately on the new pushed head.
This PR remains one commit on its updated base, preserving the stack’s linear history. Reconstruction preserves this layer's testing implementation and integration assertions while incorporating the replay-segment and failed-export retry fixes from #758.
Shared #131 qualification remains a prerequisite through #758. An updated ID does not recreate pruned metadata, and this does not resolve the separate virtual-FLAT persistence issue.