Reduce memory allocations for non-streaming async requests - #7323
Merged
Conversation
S-Saranya1
approved these changes
Aug 27, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced memory allocation for non-streaming requests made with async clients by reading the marshalled request body into a single correctly-sized buffer, instead of copying it through a growing intermediate buffer on every attempt
Motivation and Context
Profiling identified that for non-streaming bodies in the async client, we were unessecarily copy/allocating more than a full copy (because of the growing intermeidate buffer) of the request body in the SimpleHttpContentPublisher. We generally have content-length available and can use that to right-size a buffer. This change doesn't avoid the full copy (that would require larger interface updates), but at least it avoids allocating a growing intermediate buffer.
Note this is an async client only problem, sync doesn't use this path.
Modifications
Testing
Added new unit tests to cover the full SimpleHttpContentPublisher.
Benchmarks
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License