Repository navigation
fix(serve): honor container_timeout_seconds in LocalContainerMode.create_server - #6432
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
…ate_server create_server overwrote its container_timeout_seconds argument with a hard-coded 1200 before computing the health-check deadline, so ModelBuilder.deploy(container_timeout_in_seconds=N) in LOCAL_CONTAINER mode had no effect: a short timeout still blocked for 20 minutes before failing, and a model that needs longer than 20 minutes to start could not be given more time, even though the failure message tells users to increase it. Remove the override so the requested (documented default: 300) timeout is used.
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:55 — with
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:55 — with
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:56 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
LocalContainerMode.create_serveroverwrote itscontainer_timeout_secondsargument before computing the health-check deadline:ModelBuilder.deploy(container_timeout_in_seconds=N)inLOCAL_CONTAINERmode passesNdown tocreate_server, but the value was ignored:This change removes the override, so the requested timeout is used. Callers that don't pass one now get the documented default of 300 seconds, the same as v2, instead of the hard-coded 1200.
Testing:
tests/unit/mode/test_local_container_mode_timeout.pyrunscreate_serverwith a fake clock and an always-unhealthy ping. It checks the wait ends at the requested timeout, for both 60 s and 1800 s.tests/unit/mode: 12 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.