Repository navigation
fix(train): accept ModelTrainer Tag objects when creating the tuning job - #6438
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
_prepare_tags_for_tuning merges ModelTrainer.tags (typed List[Tag], so pydantic Tag objects) into the tuner's tags, which may also hold Key/Value dicts (tuner tags, JumpStart tags). The tuning request then built tags with Tag(key=tag['Key'], value=tag['Value']) for every entry, so tuning a ModelTrainer that has tags failed with TypeError: 'Tag' object is not subscriptable. Keep Tag objects as they are and convert dicts (Key/Value or key/value).
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:58 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:58 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
HyperparameterTuner._prepare_tags_for_tuningmergesModelTrainer.tagsinto the tuner's tags. Those are typedList[Tag], so they arrive as pydanticTagobjects, while the tuner's own and JumpStart tags areKey/Valuedicts. The tuning request then converted every entry with:So tuning a
ModelTrainerthat has tags failed withTypeError: 'Tag' object is not subscriptable.This change keeps
Tagobjects as they are and converts dicts, with eitherKey/Valueorkey/value.Testing:
tests/unit/train/test_tuner_tags.py: aModelTrainerwith aTagplus a tuner dict tag. Both reachHyperParameterTuningJob.createasTagobjects. It fails before this change.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.