Repository navigation
fix(core): resolve the transformers version alias in ImageRetriever HF URIs - #6445
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
…F URIs aws#5722 fixed image_uris.retrieve to build the HuggingFace image tag from the resolved transformers version (_version_for_config) instead of the raw user input, but the duplicate logic in ImageRetriever.retrieve_hugging_face_uri (reached from ImageRetriever.retrieve('huggingface', ...)) still used original_version. So an alias such as version='4.26' produced the non-existent tag ...-transformers4.26-... instead of ...-transformers4.26.0-..., and when version was omitted (auto-selected) the tag contained 'transformersNone'. Apply the same fix to ImageRetriever.
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A (follow-up to #5722)
Description of changes:
#5722 fixed
image_uris.retrieveto build the HuggingFace image tag from the resolved transformers version, using_version_for_config(version, config)instead of the raw input. The same logic is duplicated inImageRetriever.retrieve_hugging_face_uri, whichImageRetriever.retrieve("huggingface", ...)calls, and that copy still usedoriginal_version:version="4.26"produced the non-existent tag...-transformers4.26-gpu-...instead of...-transformers4.26.0-gpu-...;versionomitted, so it's auto-selected, the tag contained the literaltransformersNone.This change applies the same fix to
ImageRetriever.Testing:
ImageRetrieverreturns the same URI asimage_uris.retrievefor an alias version, and an omitted version doesn't producetransformersNone. Both fail before this change.test_image_retriever.pyandtests/unit/image_uris: 288 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.