Repository navigation
fix(core): truncate the Run failure status message to the API limit - #6446
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
When an exception escapes a 'with Run(...)' block, Run.__exit__ records it as the trial component's failure status with message=str(exc_value). The UpdateTrialComponent API limits Status.Message to 1024 characters, so a long exception message (a stack dump, an OOM message) made close() fail with a ValidationException from the service. That error replaced the user's original exception, and the run was never marked Failed or given an end time. v2 truncates the message (aws#5276); the v3 port lost it. Truncate the message to MAX_STATUS_MESSAGE_LEN (1024), as v2 does.
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 12, 2026 17:59 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A (v2 equivalent: #5276)
Description of changes:
When an exception escapes a
with Run(...)block,Run.__exit__records it as the trial component's failure status withmessage=str(exc_value).The
UpdateTrialComponentAPI limitsStatus.Messageto 1024 characters (TrialComponentStatusMessage). A long exception message, such as a stack dump or an OOM message, therefore makesclose()fail with aValidationExceptionfrom the service. That error replaces the user's original exception, and the run is never marked Failed or given an end time.v2 truncates the message with
MAX_STATUS_MESSAGE_LEN = 1024(#5276); the v3 port lost that. This change restores it.Testing:
tests/unit/experiments/test_run_exit.py: a 2000-character exception is stored as a 1024-character message, and a short one is unchanged. The long case fails before this change.tests/unit/experiments: 9 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.