fix: remove duplicate REJECT rule in p2p.mdx#1367
Open
Siriron wants to merge 1 commit intobase:masterfrom
Open
fix: remove duplicate REJECT rule in p2p.mdx#1367Siriron wants to merge 1 commit intobase:masterfrom
Siriron wants to merge 1 commit intobase:masterfrom
Conversation
Two consecutive rules in the Block Validation section said the same thing: - `[REJECT]` if the block is on the V1 topic and has withdrawals - `[REJECT]` if the block is on the V1 topic and has a withdrawals list Removed the first (less precise) duplicate. "Has a withdrawals list" is the correct, specific phrasing.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Removed a duplicate validation rule in the Block Validation section of
docs/base-chain/specs/protocol/consensus/p2p.mdx.Two consecutive lines said the same thing:
[REJECT]if the block is on the V1 topic and has withdrawals[REJECT]if the block is on the V1 topic and has a withdrawals listKept the second (more precise) phrasing and removed the first.
Notes to reviewers
Single line removal, no content change — just deduplication.
How has it been tested?
Verified by reading the raw file. Both rules describe the same condition.