Skip to content

Handle Unicode decimal input consistently #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeforester merged 1 commit into from
Aug 7, 2026
Merged

Handle Unicode decimal input consistently #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/python/base_cli/history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ def display_command(cli_name: str, argv: list[str]) -> str:


def parse_positive_int(option: str, value: str) -> int:
if not value.isdigit():
if not value.isdecimal():
raise ValueError(f"Option '{option}' must be a positive integer.")
amount = int(value)
if amount <= 0:
Expand Down
9 changes: 9 additions & 0 deletions tests/test_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,15 @@ def test_msvcrt_backend_uses_a_private_sidecar_lock(self) -> None:

self.assertEqual(fake_msvcrt.calls, [(_FakeMsvcrt.LK_LOCK, 1), (_FakeMsvcrt.LK_UNLCK, 1)])


class PositiveIntegerTests(unittest.TestCase):
def test_parse_positive_int_rejects_digit_like_non_decimal_characters(self) -> None:
with self.assertRaisesRegex(ValueError, "Option '--limit' must be a positive integer"):
history.parse_positive_int("--limit", "²")

def test_parse_positive_int_accepts_decimal_digits(self) -> None:
self.assertEqual(history.parse_positive_int("--limit", "١٢"), 12)

def test_msvcrt_sidecar_initialization_race_is_tolerated(self) -> None:
fake_msvcrt = _FakeMsvcrt()
original_write = history.os.write
Expand Down