refactor: make command protocol consumer-owned - #29
Merged
Conversation
codeforester
marked this pull request as ready for review
August 1, 2026 02:55
codeforester
added a commit
to basefoundry/base
that referenced
this pull request
Aug 1, 2026
## Summary - add a Base-owned command protocol adapter with all Base record schemas - preserve `BASE_COMMAND_PROTOCOL_V1` for the Bash peer while generic base-cli uses its neutral protocol header - route Base Python producers and decoders through the consumer adapter - document the ownership boundary and update the cross-language protocol test ## Validation - `PYTHONPATH=/Users/rameshhp/work/base-cli-worktrees/27-protocol-schemas/lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest -q` - `931 passed, 1 skipped, 248 subtests passed` - full pylint suite passes - focused command-protocol BATS suite: 9 passed - `git diff --check` Depends on basefoundry/base-cli#29. Fixes #1843
This was referenced Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMAND_PROTOCOL_V1as the neutral default while allowing consumers to preserve legacy headersValidation
uv run --extra dev pytest -qThe coordinated Base adapter migration is in basefoundry/base#1843.
Fixes #27