Skip to content

refactor: make Base own CLI context configuration - #1842

Merged
codeforester merged 2 commits into
mainfrom
enhancement/1841-20260731-consumer-owned-context-config
Aug 1, 2026
Merged

refactor: make Base own CLI context configuration#1842
codeforester merged 2 commits into
mainfrom
enhancement/1841-20260731-consumer-owned-context-config

Conversation

@codeforester

Copy link
Copy Markdown
Collaborator

Summary

  • move Base-owned UserConfig dataclasses and parsing types into base_cli_adapters
  • adapt Base's profile to pass opaque consumer configuration and project its workspace root through the generic profile callback
  • replace Base's reads of the removed Context.base_home field with neutral Context.application_home

Validation

  • PYTHONPATH=/Users/rameshhp/work/base-cli-worktrees/23-generalize-context-config-api/lib/python:cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest cli/python -q
  • 841 passed, 1 skipped, 248 subtests passed
  • git diff --check

Depends on basefoundry/base-cli#26.

Fixes #1841

@codeforester
codeforester marked this pull request as ready for review August 1, 2026 02:41
@codeforester
codeforester requested a review from a team as a code owner August 1, 2026 02:41
@codeforester
codeforester merged commit 59d2111 into main Aug 1, 2026
28 checks passed
@codeforester
codeforester deleted the enhancement/1841-20260731-consumer-owned-context-config branch August 1, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Base to consumer-owned base-cli context and configuration

1 participant