Skip to content

Environment variables starting with BEGIN_ should not pass validation #144

Open

Description

@macdonst

The CLI/API should not allow users to set environment variables that start with BEGIN_.

Activity

  1. ryanblock commented on Apr 11, 2023

    @ryanblock
    Member

    This should strictly be an API side validation error, although I’m open to relaxing this rule if we feel there is cause to allow it. We will need to have some reserved / internal env var namespace, though!

  2. macdonst commented on Apr 11, 2023

    @macdonst
    MemberAuthor

    @ryanblock yup, I realize the fix will lie in the API code but I wanted to make sure we test it from the CLI to return a good error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions