build: sync infra to 749c558 for CMake 4.4 and libc++ _FORTIFY_SOURCE - #81
Closed
steve-downey wants to merge 1 commit into
Closed
build: sync infra to 749c558 for CMake 4.4 and libc++ _FORTIFY_SOURCE#81steve-downey wants to merge 1 commit into
steve-downey wants to merge 1 commit into
Conversation
Picks up three upstream infra commits, both of which fix CI breakage:
- enable-experimental-import-std.cmake gains the CMake 4.4.0 gate. The
CMAKE_EXPERIMENTAL_CXX_IMPORT_STD UUID changes with each CMake release,
so after the recent bump from 4.3.4 to 4.4.0 the 4.3.0 branch no longer
matched and `import std` builds stopped enabling the feature.
- llvm-libc++-toolchain.cmake appends -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0
alongside -stdlib=libc++.
Both vendored files match bemanproject/infra at the pinned hash exactly; the
upstream range touches only these two files, so nothing else needed syncing.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
infra/from7b66b85to749c558, picking up three upstream commits. Both changed files fix real CI breakage.enable-experimental-import-std.cmake— CMake 4.4.0 gate. TheCMAKE_EXPERIMENTAL_CXX_IMPORT_STDUUID changes with each CMake release. After #68 bumped cmake from 4.3.4 to 4.4.0, theVERSION_GREATER_EQUAL "4.3.0"branch no longer matched a supported UUID, soimport stdbuilds stopped enabling the feature.llvm-libc++-toolchain.cmake—_FORTIFY_SOURCE. Now appends-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0alongside-stdlib=libc++.Verification
Both vendored files match
bemanproject/infraat the pinned hash byte-for-byte — no hand-edited drift:The upstream range touches only those two files, so nothing else needed syncing:
Split out from #80 (test coverage) so it can land independently — that PR's CI may well be waiting on this.
🤖 Generated with Claude Code