Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository to a newer revision of the bemanproject/execution dependency and aligns the task library/tests with API changes by relying on beman::execution::inline_scheduler instead of maintaining a task-local inline scheduler implementation.
Changes:
- Bump
bemanproject/executionFetchContentGIT_TAG. - Remove
beman::task::detail::inline_scheduler(header + test) and switch call sites/tests tobeman::execution::inline_scheduler. - Adjust build/test/example CMake lists to drop removed sources/targets.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Updates the execution dependency GIT_TAG. |
| include/beman/task/task.hpp | Re-exports inline_scheduler from beman::execution and updates includes accordingly. |
| include/beman/task/detail/task.hpp | Drops now-unneeded include of the removed inline scheduler header. |
| include/beman/task/detail/promise_type.hpp | Drops now-unneeded include of the removed inline scheduler header. |
| include/beman/task/detail/promise_env.hpp | Reorders query(...) overloads (no functional change intended). |
| include/beman/task/detail/inline_scheduler.hpp | Removes the task-local inline scheduler implementation. |
| src/beman/task/CMakeLists.txt | Removes the deleted header from the exported header file set. |
| tests/beman/task/CMakeLists.txt | Removes the deleted inline scheduler test from the test list. |
| tests/beman/task/inline_scheduler.test.cpp | Deletes tests targeting the removed task-local inline scheduler. |
| tests/beman/task/task_scheduler.test.cpp | Removes include of the deleted task-local inline scheduler header. |
| tests/beman/task/state_base.test.cpp | Switches scheduler usage to beman::execution::inline_scheduler. |
| tests/beman/task/scheduler_of.test.cpp | Updates expected scheduler type to beman::execution::inline_scheduler. |
| tests/beman/task/promise_type.test.cpp | Switches scheduler usage/initialization to beman::execution::inline_scheduler. |
| tests/beman/task/promise_base.test.cpp | Switches scheduler usage to beman::execution::inline_scheduler. |
| examples/bulk.cpp | Removes a local par tag definition; keeps example compiling standalone but it’s no longer built by default. |
| examples/CMakeLists.txt | Drops bulk from the examples list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.