Skip to content

[1.4] core: frontend: kraken: ExtensionCreationModal: Populate permissions correctly - #4420

Merged
patrickelectric merged 2 commits into
bluerobotics:1.4-devfrom
patrickelectric:fix-extension-permissions-14
Sep 10, 2026
Merged

patrickelectric merged 2 commits into
bluerobotics:1.4-devfrom
patrickelectric:fix-extension-permissions-14

Conversation

@patrickelectric

Copy link
Copy Markdown
Member

Properly loads permissions only if they contain keys, since they are empty objects by default.

Cherry-pick of #3556
Cherry-pick of #4419

Fixes #4416

image

Williangalvani and others added 2 commits September 9, 2026 21:27
…correctly

Properly loads permissions only if they contain keys, since they are
empty objects default.

Fixes bluerobotics#4416
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Cherry-pick backport to 1.4-dev fixing populatePermissions() in core/frontend/src/components/kraken/modals/ExtensionCreationModal.vue. The prior if (user_permissions) branch was always truthy (parsed '{}' yields {}, which is truthy in JS), so default extension.permissions was never applied. The fix uses Object.keys(user_permissions).length > 0 and early-returns, falling back to defaults otherwise.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@patrickelectric
patrickelectric requested a review from a team September 9, 2026 21:30
@patrickelectric
patrickelectric requested a review from a team September 9, 2026 21:49
@patrickelectric
patrickelectric enabled auto-merge (rebase) September 10, 2026 11:32
@patrickelectric
patrickelectric merged commit d16039e into bluerobotics:1.4-dev Sep 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants