feat(uploads-manager): add enableModernizedUploads feature flag to ContentUploader#4571
Merged
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughAdds an opt-in ChangesModernized uploads feature flag
Sequence DiagramsequenceDiagram
participant User
participant ContentUploader
participant ThemingStyles
participant UploadsManagerBP
participant UploadsManager
participant DroppableContent
User->>ContentUploader: mount/render
ContentUploader->>ContentUploader: check enableModernizedUploads
alt enabled
ContentUploader->>ThemingStyles: include theming
ContentUploader->>UploadsManagerBP: render modern UploadsManagerBP (items=[])
else disabled
ContentUploader->>ContentUploader: check useUploadsManager
alt useUploadsManager true
ContentUploader->>UploadsManager: render legacy UploadsManager
else
ContentUploader->>DroppableContent: render DroppableContent + Footer
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/elements/content-uploader/__tests__/ContentUploader.test.js (1)
775-785: ⚡ Quick winAssert the modernized component positively (not only legacy absence).
Lines 775-785 only verify that legacy components are absent. Add a positive assertion for the modernized uploads component so the flag contract can’t pass with an accidental null render.
✅ Suggested test hardening
+import { UploadsManager as UploadsManagerBP } from '`@box/uploads-manager`'; import UploadsManager from '../UploadsManager'; import DroppableContent from '../DroppableContent'; ... test('should render modernized uploads placeholder when enableModernizedUploads is true', () => { const wrapper = getWrapper({ enableModernizedUploads: true }); + expect(wrapper.find(UploadsManagerBP)).toHaveLength(1); expect(wrapper.find(UploadsManager)).toHaveLength(0); expect(wrapper.find(DroppableContent)).toHaveLength(0); }); test('should render modernized uploads placeholder even when useUploadsManager is true', () => { const wrapper = getWrapper({ enableModernizedUploads: true, useUploadsManager: true }); + expect(wrapper.find(UploadsManagerBP)).toHaveLength(1); expect(wrapper.find(UploadsManager)).toHaveLength(0); expect(wrapper.find(DroppableContent)).toHaveLength(0); });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/elements/content-uploader/__tests__/ContentUploader.test.js` around lines 775 - 785, The tests only assert legacy components are absent; add a positive assertion that the modernized uploads component is rendered when enableModernizedUploads is true. Update both tests that call getWrapper(...) to also assert presence of the modernized component (e.g. expect(wrapper.find(ModernizedUploadsPlaceholder)).toHaveLength(1)) or, if the component is rendered with a test id, expect(wrapper.find('[data-testid="modernized-uploads"]')).toHaveLength(1); keep the existing checks for UploadsManager and DroppableContent unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/elements/content-uploader/__tests__/ContentUploader.test.js`:
- Around line 775-785: The tests only assert legacy components are absent; add a
positive assertion that the modernized uploads component is rendered when
enableModernizedUploads is true. Update both tests that call getWrapper(...) to
also assert presence of the modernized component (e.g.
expect(wrapper.find(ModernizedUploadsPlaceholder)).toHaveLength(1)) or, if the
component is rendered with a test id,
expect(wrapper.find('[data-testid="modernized-uploads"]')).toHaveLength(1); keep
the existing checks for UploadsManager and DroppableContent unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ec5001c4-a759-43a4-b1ca-eebba2a731d1
📒 Files selected for processing (4)
scripts/jest/jest.config.jssrc/elements/content-uploader/ContentUploader.tsxsrc/elements/content-uploader/__tests__/ContentUploader.test.jssrc/elements/content-uploader/stories/ContentUploader.stories.js
dealwith
changed the title
dealwith
force-pushed
the
create-feature-flag-in-content-uploader
branch
from
e7246f1 to
2d34e98
Compare
olehrybak
approved these changes
May 21, 2026
dlasecki-box
approved these changes
May 21, 2026
tjiang-box
reviewed
May 21, 2026
tjiang-box
approved these changes
May 21, 2026
dealwith
force-pushed
the
create-feature-flag-in-content-uploader
branch
from
73fb1e5 to
62792f4
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/elements/content-uploader/ContentUploader.tsx`:
- Around line 1302-1307: The modernized branch renders <UploadsManagerBP
items={[]}> while legacy upload lifecycle/queue logic may still run, hiding
active uploads; update the enableModernizedUploads branch in the render path to
either (A) pass the real upload items/state instead of an empty array (use the
same source used by the legacy branch) or (B) disable/short-circuit legacy
queue/upload initialization when enableModernizedUploads is true (e.g., check
enableModernizedUploads before invoking the legacy upload lifecycle or
queue-start functions). Locate references to enableModernizedUploads and
UploadsManagerBP in ContentUploader.render (or the surrounding component
methods) and apply the guard so active uploads are never started/managed by
hidden/empty UploadsManagerBP.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fd0b083e-e705-4748-b125-fc5c2b9eb8ca
📒 Files selected for processing (4)
scripts/jest/jest.config.jssrc/elements/content-uploader/ContentUploader.tsxsrc/elements/content-uploader/__tests__/ContentUploader.test.jssrc/elements/content-uploader/stories/ContentUploader.stories.js
dealwith
force-pushed
the
create-feature-flag-in-content-uploader
branch
from
62792f4 to
55f3e27
Compare
Collaborator
Author
|
@Mergifyio queue |
Contributor
☑️ This pull request is already queued |
Contributor
Merge Queue Status
This pull request spent 37 seconds in the queue, including 4 seconds running CI. Required conditions to merge
|
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enableModernizedUploadsfeature flag prop toContentUploader(defaultfalse).enableModernizedUploads=truerenders the modernized uploads placeholder (@box/uploads-manager).UploadsManagerwhenuseUploadsManager=true,DroppableContentflow when false).@box/uploads-managerin tests.withModernizedUploads).Test plan
yarn test src/elements/content-uploader/__tests__/ContentUploader.test.jswithModernizedUploadsrenders the modernized placeholder path.enableModernizedUploads=false+useUploadsManager=truestill renders legacyUploadsManager.enableModernizedUploads=false+useUploadsManager=falsestill rendersDroppableContent.Notes
ready-to-mergelabel.Summary by CodeRabbit
New Features
Tests
Chores