feat(content-uploader): Implement cancel all confirmation modal by dealwith · Pull Request #4579 · box/box-ui-elements

dealwith · 2026-05-20T20:46:15Z

4/5 PR in the queue:

Summary by CodeRabbit

Release Notes

New Features
- Added a confirmation modal when canceling all uploads, allowing users to confirm the action or keep uploading
- Full internationalization support for the confirmation dialog
Tests
- Added comprehensive test coverage for the confirmation modal and upload cancellation workflow

coderabbitai · 2026-05-20T20:46:22Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

i18n/en-US.properties is excluded by !i18n/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 92ba4043-df41-404a-9d3e-c50df1c18e82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

This PR adds a confirmation modal for canceling all in-progress uploads in the ContentUploader component. A new reusable CancelAllUploadsModal component is created with internationalized text, integrated into ContentUploader with state and handlers, and both the modal and integration are covered by tests.

Changes

Cancel All Uploads Modal and Integration

Layer / File(s)	Summary
Cancel All Uploads Modal component and i18n `src/elements/content-uploader/CancelAllUploadsModal.tsx`, `src/elements/content-uploader/messages.ts`, `src/elements/content-uploader/__tests__/CancelAllUploadsModal.test.tsx`	`CancelAllUploadsModal` wraps `AlertModal` with props for `isOpen`, `onConfirm`, and `onDismiss` callbacks. Message IDs, default English text, and descriptions are exported from `messages.ts` for modal heading, body, button labels, and close-label aria. Tests verify rendering when open, correct callback invocation per button, and no render when closed.
ContentUploader modal wiring and confirmation handlers `src/elements/content-uploader/ContentUploader.tsx`, `src/elements/content-uploader/__tests__/ContentUploader.test.js`	`isCancelAllModalOpen` state tracks modal visibility. `handleCancelAllClick` opens the modal from the modernized `UploadsManagerBP.onCancelAll` callback. `handleCancelAllConfirm` cancels only in-progress and pending uploads and closes the modal; `handleCancelAllDismiss` closes without canceling. Integration tests verify modal opens on action, confirm handler cancels and closes, and dismiss handler closes without canceling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

box/box-ui-elements#4577: Adds the underlying bulk cancel and STATUS_CANCELED handlers that the main PR's confirmation modal wraps.
box/box-ui-elements#4571: Also modifies ContentUploader.tsx and the modernized UploadsManagerBP manager routing.

Suggested labels

ready-to-merge

Suggested reviewers

jpan-box
olehrybak
reneshen0328

Poem

🐰 A modal so fair, with buttons so bright,
Confirms when you click, dismisses with might,
In upload we trust, with messages true,
No cancellations surprise—we show what we'll do!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description lacks substantive details about the implementation; it only contains PR queue context and merge process guidance from the template.	Add a meaningful description explaining what the confirmation modal does, why it was added, and any relevant implementation details or trade-offs.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: implementing a cancel all confirmation modal for the content-uploader component.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch implement-cancel-all-confirmation-modal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

The base branch was changed.

The Cancel All button on the modernized uploads manager now opens a confirmation dialog instead of canceling immediately. Confirming runs handleCancelAllUploads; dismissing leaves uploads untouched. Modal uses @box/blueprint-web AlertModal with localized copy and danger-styled primary action.

- Sort imports alphabetically. - Rename handleCancelAllRequest to handleCancelAllClick and group with cancel-all handlers. - Drop redundant cancelAllUploadsModal* prefix from message keys (heading, body, confirmButton, keepUploadingButton, closeLabel). - Rename keepButton to keepUploadingButton for clearer intent. - Match modal body via literal string instead of regex.

dealwith · 2026-05-29T15:52:14Z

https://github.com/Mergifyio queue

mergify · 2026-05-29T15:52:33Z

jpan-box

All addressed — handler reordering, naming, message keys, and test updates all look good.

mergify · 2026-05-29T16:24:03Z

dealwith changed the base branch from master to implement-cancelled-state-uploads-manager May 21, 2026 09:39

olehrybak previously approved these changes May 27, 2026

View reviewed changes

dealwith marked this pull request as ready for review May 27, 2026 14:26

dealwith requested review from a team as code owners May 27, 2026 14:26

dealwith changed the title ~~Implement cancel all confirmation modal~~ feat(content-uploader): Implement cancel all confirmation modal May 27, 2026