move confirmation_callback_t constructors out of line and fix move semantics - #1620
Open
erics118 wants to merge 5 commits into
Open
move confirmation_callback_t constructors out of line and fix move semantics#1620erics118 wants to merge 5 commits into
erics118 wants to merge 5 commits into
Conversation
declare special member functions out of line, so codegen is emitted once rather than in every tu
declare special members out of line for large objects (message, embed, component, user, channel, guild, slashcommand, interaction, command_option)
for json_interface only types (ban, invite, prune, dtemplate, voiceregion, voicestate, auditlog, guild_command_permissions, onboarding, application_role_connection and its nested metadata, automod_metadata) virtual destructor has to stay, and we declare rule of 5 to ensure proper move semantics for managed types, (application, integration, stage_instance, sticker, user_identified, automod_rule) the declared destructor is redundant, so we remove it, so it supports proper move semantics now, confirmation_callback_t is known to be nothrow moveable
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
documentation
…l member functions inline
msvc computes noexcept(false) always, so this would be incorrect on msvc no change for all others
braindigitalis
requested changes
Jul 25, 2026
braindigitalis
left a comment
braindigitalis
left a comment
Contributor
There was a problem hiding this comment.
needs comments, and we can't really just get rid of the destructors as it breaks the expectations of the managed base class.
| interaction_response() = default; | ||
| interaction_response(const interaction_response&); | ||
| interaction_response(interaction_response&&); | ||
| interaction_response& operator=(const interaction_response&); |
Contributor
There was a problem hiding this comment.
documentation needed
| */ | ||
| interaction(); | ||
|
|
||
| interaction(const interaction&) = default; |
Contributor
There was a problem hiding this comment.
documentation needed
| @@ -1415,6 +1429,11 @@ class DPP_EXPORT guild_command_permissions : public json_interface<guild_command | |||
| */ | |||
| guild_command_permissions(); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
documentation needed
| */ | ||
| slashcommand(const std::string &_name, const slashcommand_contextmenu_type _type, const dpp::snowflake _application_id); | ||
|
|
||
| slashcommand(const slashcommand&) = default; |
Contributor
There was a problem hiding this comment.
documentation needed
| */ | ||
| automod_metadata(); | ||
|
|
||
| automod_metadata(const automod_metadata&) = default; |
Contributor
There was a problem hiding this comment.
documentation needed
| /** Constructor */ | ||
| ban(); | ||
|
|
||
| ban(const ban&) = default; |
Contributor
There was a problem hiding this comment.
documentation needed
| integration(); | ||
|
|
||
| /** Default destructor */ | ||
| ~integration() = default; |
Contributor
There was a problem hiding this comment.
if it is managed a user could choose to put it in a cache. without the virtual dtor, that becomes ub.
| */ | ||
| sticker(); | ||
|
|
||
| virtual ~sticker() = default; |
Contributor
There was a problem hiding this comment.
same here user could choose to cache it with a custom cache. that's the point of managed
| public: | ||
| prune() = default; | ||
|
|
||
| prune(const prune&) = default; |
Contributor
There was a problem hiding this comment.
documentation needed
| confirmation_callback_t() = default; | ||
| confirmation_callback_t(); | ||
|
|
||
| confirmation_callback_t(const confirmation_callback_t&); |
Contributor
There was a problem hiding this comment.
documentation needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we fix move semantics for two types of classes:
json_interface only types: (ban, invite, prune, dtemplate, voiceregion, voicestate, auditlog, guild_command_permissions, onboarding, application_role_connection and its nested metadata, automod_metadata)
proper move semantics
managed types: (application, integration, stage_instance, sticker, user_identified, automod_rule)
confirmation_callback_t special member functions are moved out of line so codegen is emitted once rather than in every translation unit, saving compile time (for ppl using the library, no big change to DPP compile times)
similarly, we also move special member functions for message, embed, component, user, channel, guild, slashcommand, interaction, command_option out of line to also save compile time
Code change checklist