Add --matrix-param argument to eval#141
Conversation
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
There was a problem hiding this comment.
I think tests/evals/js/eval-matrix-param-terminate/ needs a fixture.json.
There was a problem hiding this comment.
oops! added
| }); | ||
| } | ||
|
|
||
| if (btEvalMains.length > 0) { |
There was a problem hiding this comment.
don't we need to honour the matrix on this path too? We should alteast print a warning if someone tries to use a matrix and they fall back into this path.
There was a problem hiding this comment.
thanks this is a good callout, I didn't even realize this existed. as I was thinking through how we would support it if felt like it would be a lot of added complexity. I think we can add this sort of support if needed but to keep things simple while nobody is using this feature I think we can ship without support for params on btEvalMain and add support if we get feedback from users. updated the PR to fail and log an error message if using params with btEvalMain
Adds the
--matrix-paramflag tobt evalwill create all combinations of arguments when multiple flags used.
--matrix-paramhashes are appended to eval name and experiment name to ensure uniqueness and make it easier to differentiate between multiple experiments in the CLI and links.If the value contains a comma, must use a JSON string containing an array