Skip to content

Query timeout with callback never emits 'error' #3812

Description

@mikemasam

client.query({ text, query_timeout }, cb) + query.on('error'): timeout only reaches cb, event never fires. Success path does both (cb + 'end').

Query.handleError is callback-xor-emit by design (locked by query-error-handling-prepared-statement-tests.js), so blind dual-emit (#3811) breaks back-compat.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions