Repository navigation
feat(v4): add workspace download helpers - #229
Open
MagMueller wants to merge 2 commits into
Open
MagMueller wants to merge 2 commits into
MagMueller wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
V4 workspaces could list and upload files, but neither SDK exposed a high-level download helper.
download()anddownload_all().download()anddownloadAll().Each transfer requests a fresh presigned URL immediately before downloading, streams to a sibling temporary file, and atomically replaces the destination. Failed transfers remove the temporary file and preserve an existing destination. Bulk downloads preserve nested paths and reject traversal.
Tests
git diff --checkpassed.Summary by cubic
Adds high-level download helpers to the Python and TypeScript V4 workspace SDKs, so callers can pull workspace files to disk without managing presigned URLs manually.
New Features
download()anddownload_all(); TypeScript addsdownload()anddownloadAll().Written for commit ea16657. Summary will update on new commits.