Fix/sdk 7229 buildstop resilience - #143
Merged
rahulpsq merged 2 commits intoAug 14, 2026
Merged
Conversation
…ps (SDK-7229) The build-stop PUT is the only signal that closes a TRA build. SDK-7061 added a 3-attempt retry, but the whole window was ~1.5s (500ms + 1000ms) — shorter than a typical corporate DNS/proxy blip — and the request carried no timeout at all, so a connection that never settled could stall onComplete indefinitely. On top of that, every failure was logged as a bare `TypeError: fetch failed`. Node's fetch keeps the actionable detail (ENOTFOUND, ECONNRESET, proxy refusal) on `error.cause`, which plain interpolation drops — so a failed build stop was indistinguishable from any other network fault in a customer log. - Widen the retry to STOP_BUILD_MAX_ATTEMPTS (4) with exponential backoff (1s/2s/4s), capped by a STOP_BUILD_TOTAL_BUDGET_MS (30s) wall-clock deadline. The deadline bounds the added shutdown cost regardless of attempt count. - Bound each attempt with an AbortController (STOP_BUILD_ATTEMPT_TIMEOUT_MS, 10s, clamped to the remaining budget), and report an aborted attempt as a timeout rather than a generic AbortError. - Add describeErrorWithCause() and use it on every build-stop failure log so the underlying transport reason is recorded. Observed against the customer's exact failure mode (fetch rejecting with an ENOTFOUND cause): 1 attempt before SDK-7061, 3 attempts / 1.5s on 9.33.1, and 4 attempts / 7.0s here — with the DNS cause now present in the log line.
rahulpsq
requested review from
Bhargavi-BS and
xxshubhamxx
and removed request for
a team
August 14, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.