Fix/sdk 7233 wdio test file path and binary update - #145
Merged
rahulpsq merged 2 commits intoAug 14, 2026
Merged
Conversation
…-aware (SDK-7233) WebdriverIO-mocha test results never reached Test Reporting when the project was not a git checkout. test_file_path was gated on a resolvable git root, so outside a git checkout it went out as undefined. The binary dereferences that field in MochaModule.makeFileDetails (path.relative) and throws before the event is uploaded, so every TestRunStarted/TestRunFinished was dropped while CBTSessionCreated still went through — sessions appeared on the dashboard but the test rows never resolved. Send the absolute spec path instead. The binary re-bases it itself against pathProject and versionControlInfo.root (its local is named absoluteTestFilePath), so a pre-relativised value also produced a wrong file_name. The binary-side guard for this has shipped since 1.22.x, but affected users never received it: downloadLatestBinary short-circuits when a binary merely exists on disk, never comparing versions. It is only ever reached after the server reports an update, so the binary it finds is stale by construction and the update is skipped on every run — pinning a machine to the first binary it ever downloaded. Compare against the target version instead, preferring the server-reported one so a custom BROWSERSTACK_BINARY_URL keeps its peer-race handling. Also fixes two latent faults on the same path: a fetch failure left the download promise pending forever, and the write stream's error listener was registered after the first await, so an early failure surfaced as an uncaught exception in the user's test process.
rahulpsq
requested review from
harshit-browserstack and
yashdsaraf
and removed request for
a team
August 14, 2026 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.