Fix/sdk 7270 session name per test - #148
Merged
rahulpsq merged 2 commits intoAug 14, 2026
Merged
Conversation
… worker teardown (SDK-7270) Since 9.27 the SDK self-bootstraps the platform binary, so BrowserstackCLI.isRunning() is true on every run and service.ts skips the legacy per-test rename. Ownership moved to automateModule, which records the per-test name in sessionMap but issues no PUT until onAfterExecute -- reached only from service.ts's after() hook, i.e. once at worker teardown. Every session's name therefore depended on a single event at the very end of the worker. Suites that reload the session per test have already closed those sessions by then, and a worker that never reaches after() (interrupted run, hard exit, crash) never fires onAfterExecute at all -- leaving every session on its creation-time sessionName capability. Name the session from onBeforeTest, while it is still the live session, via a new flushSessionName() helper de-duped on SessionData.appliedName. onAfterExecute now calls the same helper, becoming a final sweep that no-ops for sessions already named. Restores the pre-9.27 per-test timing with no extra API calls in the steady state. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
rahulpsq
requested review from
07souravkunda and
rounak610
and removed request for
a team
August 14, 2026 14:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this about?
Related Jira task/s
Release (mandatory for every PR — required for the
ready-for-reviewlabel)Version bump: (required — tick exactly one)
Release notes type: (optional)
Release notes (customer-facing): (optional but encouraged)
Release notes (internal): (required — engineer-facing; what actually changed / why)
Checklist
PR Validations
Run Tests: Comment RUN_TESTS to trigger sanity tests.