feat: add BUF_WASM_MAX_MEMORY_BYTES env var to configure WASM memory limit#4504
Closed
paultyng wants to merge 1 commit into
Closed
feat: add BUF_WASM_MAX_MEMORY_BYTES env var to configure WASM memory limit#4504paultyng wants to merge 1 commit into
paultyng wants to merge 1 commit into
Conversation
…limit The WASM plugin sandbox is hardcoded to 512 MiB. Larger check plugins (e.g., those embedding the AEP api-linter with transitive gRPC deps) can OOM during init before any proto analysis begins. Add BUF_WASM_MAX_MEMORY_BYTES environment variable to override the default. The WithMaxMemoryBytes runtime option already exists but was never exposed to users. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
Contributor
|
Hey @paultyng, thanks for the PR. From your issue this morning we bumped the memory limits from 512MiB to 1GiB: #4503. This will get set in the next release. Looked into exposing it as a variable but this would give us potentially different limits across the CLI and the BSR. Ideally plugins work the same wherever they are run. For your use case the AEP should work out of the box now. Does this approach work for you? |
Author
|
@emcfarlane sorry I missed that! thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WASM plugin sandbox is hardcoded to 512 MiB. Larger check plugins (e.g., those embedding the AEP api-linter with transitive gRPC deps) can OOM during init before any proto analysis begins.
Add BUF_WASM_MAX_MEMORY_BYTES environment variable to override the default. The WithMaxMemoryBytes runtime option already exists but was never exposed to users.