5.x: remove deprecations

[LordSimal]

Haven't fully tried it with a test app but this removes the ToolbarHelper::dump() method which was marked as deprecated.

The tests working with SimpleXmlElement created some problems for me locally since the JS contained in the Debugger Header did not parse well as XML. Therfore I changed the test implementation to use DOMDocument.

Update: Nope, there are definitely some problems still present.

[LordSimal]

I am probbaly misunderstanding things here but since we dropped ToolbarHelper::dump() one has to use ToolbarHelper::dumpNodes()

This one requires an array of nodes of type \Cake\Error\Debug\NodeInterface which can be created like

$nodeArray = [Debugger::exportVarAsNodes($request->getQueryParams())];

because Debugger::exportVarAsNodes() will always be 1 root Node containing all child nodes.

Therefore I had to do stuff like

'query' => [Debugger::exportVarAsNodes($request->getQueryParams())],
'data' => [Debugger::exportVarAsNodes($request->getData())],
'cookie' => [Debugger::exportVarAsNodes($request->getCookieParams())],
'get' => [Debugger::exportVarAsNodes($_GET)],

which feels wrong to me because it will created an output like this:

I seem to be missing something here so that we can also dump a single node. Should I just create that method in the ToolbarHelper?

[markstory]

Should I just create that method in the ToolbarHelper?

That seems like the correct approach. Accepting a list or single node in the existing method could also be a good approach.

[LordSimal]

This looks better

Now there is only the issue of the duplicate copy button but I think this is something we need to fix in the core.

[markstory]

Looks good!

[LordSimal]

The duplicate copy buttons where happening because the debug_kit and cake core adds a separate div with the class cake-debug. But debug_kit doesn't need to do that anymore.

The copy button gets added to all .cake-debug divs via JS. Thats why it was duplicated.