5.x: upgrade to PHPUnit 10#940
Merged
Merged
Conversation
ADmad
reviewed
May 30, 2023
| "DebugKit\\Test\\": "tests/", | ||
| "DebugKit\\TestApp\\": "tests/test_app/", | ||
| "DebugkitTestPlugin\\": "tests/test_app/Plugin/DebugkitTestPlugin/src/" | ||
| "DebugKit\\TestApp\\": "tests/TestApp/", |
Member
There was a problem hiding this comment.
I prefer having test_app over TestApp.
markstory
reviewed
May 31, 2023
| public function isEnabled(): bool | ||
| { | ||
| if (isset($GLOBALS['__PHPUNIT_BOOTSTRAP'])) { | ||
| if (defined('PHPUNIT_COMPOSER_INSTALL') && !$GLOBALS['FORCE_DEBUGKIT_TOOLBAR']) { |
Member
There was a problem hiding this comment.
Of course they break my hacks 😆
Contributor
Author
There was a problem hiding this comment.
Just re-introduced a new hack 😁
garas
reviewed
May 31, 2023
| $this->assertSame('Sql Log', $result->panels[11]->title); | ||
|
|
||
| $timeStamp = filemtime(Plugin::path('DebugKit') . 'webroot' . DS . 'js' . DS . 'main.js'); | ||
| $timeStamp = filectime(Plugin::path('DebugKit') . 'webroot' . DS . 'js' . DS . 'main.js'); |
Member
There was a problem hiding this comment.
It should be inject-iframe.js here and keep using filemtime.
Line was previously incorrectly updated when .js file was renamed. And ToolbarService::getToolbarUrl is using filemtime.
Contributor
Author
There was a problem hiding this comment.
I tried that but for some reason its not working... haven't looked too deep into it though.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: cakephp/cakephp#16992