Skip to content

test(ratchet): pin snapshot-handler.test.ts at main's 2654 lines - #1860

Merged
thymikee merged 1 commit into
mainfrom
fix/ratchet-pin-snapshot-handler
Aug 18, 2026
Merged

test(ratchet): pin snapshot-handler.test.ts at main's 2654 lines#1860
thymikee merged 1 commit into
mainfrom
fix/ratchet-pin-snapshot-handler

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

main is red on src/__tests__/test-file-size-ratchet.test.ts since #1843 merged: #1847 grew src/daemon/handlers/__tests__/snapshot-handler.test.ts from 2652 to 2654 lines and merged minutes before #1843 landed its pin of 2652 (measured against the merge-base #1843 had when it was last pushed). Both PRs were green in isolation; together the equality pin fires — which is the cross-PR growth it exists to catch, and a small live example of the "two green PRs, red main" case that argues for a merge queue once units overlap regularly.

This is a catch-up, not a raise: the pin moves to main's own current length, and the history rule agrees (2654 at the merge-base with origin/main).

Validation

1 file, 1 line.

#1847 grew the file 2652→2654 and merged minutes before #1843 pinned it at
2652 (measured against the merge-base #1843 had at the time). Both PRs were
green alone and main is red together — the cross-PR growth the equality pin
exists to catch, landing as a catch-up rather than a raise: the history rule
agrees (2654 at the merge-base).
@github-actions

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.31 MB 2.31 MB 0 B
JS gzip 759.2 kB 759.2 kB 0 B
npm tarball 882.5 kB 882.5 kB 0 B
npm unpacked 3.08 MB 3.08 MB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.7 ms 28.7 ms +0.9 ms
CLI --help 69.4 ms 70.8 ms +1.4 ms

Top changed chunks: no changes in the largest emitted chunks.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Aug 18, 2026
@thymikee

Copy link
Copy Markdown
Member Author

Reviewed exact 782353a4: clean and merge-ready. Current main has a 2,654-line snapshot-handler.test.ts with a stale 2,652 pin because #1847 merged immediately before #1843. This one-line catch-up equals the file’s merge-base length, so it repairs the bootstrap baseline without authorizing branch growth. The main-red/head-green evidence is non-vacuous, all exact-head checks are green, and no device evidence applies.

@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-18 18:43 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant