You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move request-scoped provider composition out of src/daemon and into root runtime composition. The daemon now consumes one neutral provider scope while exact-owner gating, wrapper order, inherited replay scope, request identity, and fail-closed provider behavior remain unchanged.
This is PR 1/3 in the #1739 terminal daemon-platform stack. It removes 15 of the 38 concrete-platform edges measured on main and also relocates the remaining neutral request/boot/install vocabulary to contracts.
Validation
Provider routing, nested replay-scope, request-context, and fail-closed parity tests pass. Typecheck, layering, fallow, build/package, Node integration, and provider integration passed on the complete stack. The full affected run reached 3,429/3,430 related tests; its sole Apple-runner concurrency timeout passed in isolation in 149 ms.
57 files are touched across the complete stack; this PR is the provider-composition slice. No docs or skills changed because the public command surface and behavior are unchanged.
P2: govern the new provider-composition owner instead of creating an unprotected second composition seam. src/platform-runtime-request-providers.ts now owns the cross-family resolver table, wrapper ordering, default Web construction, and concrete platform imports, while ADR-0019 and R13 name/protect only src/platform-runtime.ts as the canonical composition root. The move preserves behavior, but future provider additions can now smear platform composition outside the enforced owner. Make this an explicitly governed submodule of the canonical root and extend R13 with planted-red coverage, or amend the ADR and executable policy to name this second composition owner. Until then, the slice is not ready-for-human despite otherwise clean routing and green checks in progress.
Addressed in 7389a45. Provider composition now lives in the governed src/platform-runtime/request-providers.ts submodule of the canonical root, and R13 has planted-red coverage preventing another ungoverned composition owner. The exact-slice duplicate imports and unused type re-exports reported by CI are also fixed; format, lint, and Fallow pass locally.
Addressed in 0409dac. Provider composition now lives in the governed src/platform-runtime/request-providers.ts submodule of the canonical root, and R13 has planted-red coverage preventing another ungoverned composition owner. Exact-slice duplicate imports, unused type re-exports, and the coverage-only shutdown test mock are fixed; format, lint, Fallow, and the exact failed test pass locally.
Re-reviewed the rewritten head 0409dac62efa3280885670e4cf9dc39f3a5b35c1. The prior composition-boundary finding remains resolved. The only new delta updates a daemon-lifecycle test mock to supply the newly required createRequestPlatformProviders seam; it transparently executes the supplied task and does not change production behavior or weaken the composition/R13 guarantees. I found no new code issue. Exact-head substantive checks restarted and remain pending.
Exact-head evidence is now complete. The reviewed code head is unchanged, and every substantive check is green: repository guards, type/package, both coverage shards, integration, lint/format, bundle size, CodeQL, and Android/Linux/iOS/macOS smoke. The only skipped entry is the expected build-cache matrix placeholder. No code or evidence blocker remains; this is merge-ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move request-scoped provider composition out of
src/daemonand into root runtime composition. The daemon now consumes one neutral provider scope while exact-owner gating, wrapper order, inherited replay scope, request identity, and fail-closed provider behavior remain unchanged.This is PR 1/3 in the #1739 terminal daemon-platform stack. It removes 15 of the 38 concrete-platform edges measured on
mainand also relocates the remaining neutral request/boot/install vocabulary to contracts.Validation
Provider routing, nested replay-scope, request-context, and fail-closed parity tests pass. Typecheck, layering, fallow, build/package, Node integration, and provider integration passed on the complete stack. The full affected run reached 3,429/3,430 related tests; its sole Apple-runner concurrency timeout passed in isolation in 149 ms.
57 files are touched across the complete stack; this PR is the provider-composition slice. No docs or skills changed because the public command surface and behavior are unchanged.