fix(ci): publish OTA updates when a labelled pull request merges - #5130
Draft
KisaneNeko wants to merge 1 commit into
Draft
KisaneNeko wants to merge 1 commit into
KisaneNeko wants to merge 1 commit into
Conversation
The job selected on `github.event.pull_request.labels` but triggered on `push`, where there is no pull request to read labels from. The condition was never true, so the job has skipped all 69 times it has been queued since January. Trigger on a pull request closing against main instead, so the label is readable, and check that it was merged rather than just closed. `pull_request_target` rather than `pull_request` because a fork's pull request cannot read secrets, and most contributions here come from forks. Only main is ever checked out, and the token is pinned to read, so no pull request author's code runs with it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Found potential problems with the pull request:
|
KisaneNeko
marked this pull request as draft
September 23, 2026 05:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While implementing auto deploys of the demo app I noticed there's a job for OTA releases that never actually worked, this PR fixes it. Merging a PR with the
example applabel will now ship the JS bundle.NOTE: the build in the stores is on an older SDK than the repo, and
runtimeVersion.policyissdkVersion, so updates published from main can't reach it yet. This starts having a visible effect after the next native release.Related issue
None, noticed while working on #5118.
Test plan
Can't be verified before merging, since GitHub runs the workflow from main. After this lands, merging a PR labelled
example appshould produce an actual run instead of a skipped one, and an unlabelled merge should produce no run at all.