Repository navigation
fix(list): expand accordion with id 0 in a controlled AccordionGroup - #5205
Merged
Merged
Conversation
Port of #5145 to 5.0. Co-authored-by: Raphael Fakhri <rjf11@mail.aub.edu>
|
Found potential problems with the pull request:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
On 5.x, a controlled
List.AccordionGroupwithexpandedId={0}doesn't expand the accordion withid={0}, becauseexpandedIdProp || expandedIdtreats0as unset.Related issue
Port of #5145
Fixes #5144 on 5.x
Screenshots / Videos
None needed: a one-line change with a test.
Test plan
ListAccordion.test.tsx(the one from fix(list): expand accordion with id 0 in a controlled AccordionGroup #5145, in5.0's test style): withexpandedId={0}, the accordion withid={0}is expanded and the other one isn't. It fails on5.0without the change.yarn typescript,yarn lint-no-fixandyarn testpass.