Repository navigation
feat: export IconSource type - #5207
Closed
aniilchauhan wants to merge 1 commit into
Closed
aniilchauhan wants to merge 1 commit into
aniilchauhan wants to merge 1 commit into
Conversation
Most icon props take IconSource, but apps had to deep-import it from lib/typescript, and that path changed between 5.x and 6.x. Closes callstack#5189
|
Found potential problems with the pull request:
|
Collaborator
|
Duplicate of #5194 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Most icon props (
Button,IconButton,List.Icon,FAB, ...) takeIconSource, but the package does not export the type. Apps deep-import it fromlib/typescript, and that path moved between 5.x and 6.x, so the import breaks on upgrade.Related issue
Closes #5189
Screenshots / Videos
Not applicable, type-only change.
Test plan
In a consumer project,
import type { IconSource } from 'react-native-paper'resolves andconst icon: IconSource = 'camera'typechecks. No runtime change.