Repository navigation
docs(getting-started): create the Expo babel config with expo customize - #5210
Merged
Merged
Conversation
|
Found potential problems with the pull request:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In a new Expo SDK 58 app, npm can leave
babel-preset-expoonly undernode_modules/expo/node_modules, so ababel.config.jswritten from the guide fails withCannot find module 'babel-preset-expo'. The guide now creates it withnpx expo customize babel.config.js, which installs the preset. The Community CLI sample uses@react-native/babel-preset.Related issue
Part of #4991
Screenshots / Videos
None needed: docs text only.
Test plan
In a fresh
blank-typescriptapp with Paper alpha.2, the hand-written file failsnpx expo export:embed. Afternpx expo customize babel.config.jsand theenvblock, it passes and production builds rewrite Paper imports.yarn lintand the docs build pass.