Skip to content

Revert "test: reproduce #1790" pushed to main by mistake - #1791

Merged
V3RON merged 1 commit into
mainfrom
revert-1790-repro
Nov 20, 2026
Merged

V3RON merged 1 commit into
mainfrom
revert-1790-repro

Conversation

@V3RON

@V3RON V3RON commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Reverts d7bd191, which a triage agent pushed to main by mistake instead of to bug/1790-repro. It added two tests that fail on purpose (the #1790 reproduction), so main and every branch made from it would be red.

The tests come back with the fix for #1790.

Review

Spec review: skipped. Code review: skipped. Claims review: skipped.
Rounds: 0. Tokens: 0M.

A pure git revert of d7bd191, a commit pushed to main by mistake, restoring main to its reviewed state.

Assessment: complete

Written by an agent.

…rce recorded is deleted"

This reverts commit d7bd191.
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The iOS seed recording tests no longer simulate a file disappearing after lstat or test that scenario. The swap tests now check missing-file, write, and wrong-length lineage failures, including copy deletion on failure. The successful control case checks that the copy remains intact. These changes affect tests only.

Merge Risk: Minimal · up to 452a4

This revert removes tests that were pushed to main by mistake and would have left it failing. It has no production impact. The PR body check failure, a missing Review section, should be fixed in the description before merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states that the PR reverts the commit "test: reproduce #1790", which matches the PR objectives. It is specific about the change and the reason it was pushed by mistake. Title is clear, conci…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states that the PR reverts commit d7bd191, which a triage agent pushed to main by mistake. It explains that the commit added two intentionally failing tests for #1790, and that the t…
Full details: Title check

Explanation

The title states that the PR reverts the commit "test: reproduce #1790", which matches the PR objectives. It is specific about the change and the reason it was pushed by mistake. Title is clear, concise, and accurate about the main change.

Full details: Description check

Explanation

The description states that the PR reverts commit d7bd191, which a triage agent pushed to main by mistake. It explains that the commit added two intentionally failing tests for #1790, and that the tests will return with the fix. The changeset removes those tests, so the description matches the changes.

Finishing Touches

Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: f367e4f5-f117-4a3b-b0a9-22987f08730d
Commits

Reviewing files that changed from the base of the PR and between d7bd191 and 452a421.

Files selected for processing: 2

  • src/drivers/ios/index-seed-record.test.ts
  • src/drivers/ios/index-seed-swap.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@V3RON
V3RON merged commit 4d9b7ef into main Nov 20, 2026
53 of 54 checks passed
@V3RON
V3RON deleted the revert-1790-repro branch November 20, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant