Repository navigation
Conversation
…oot's free space is copied
… space is refused before copying (#1750)
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Author
Review ledgerRound 1: 2cb6d29 {"findings":[{"id":"R1","role":"code","class":"documentation 9: user docs match behaviour","outcome":"fixed","path":"website/src/content/docs/docs/using-devices/errors.mdx","round":"1","fix":"c5867fe877f2e96c9198106ef9726bbae26f40ca"},{"id":"R2","role":"claims","class":"error message names wrong operation","outcome":"fixed","path":"src/drivers/android/seeds.ts","round":"1","fix":"c5867fe877f2e96c9198106ef9726bbae26f40ca"},{"id":"R3","role":"code","class":"testing 10","outcome":"fixed","path":"src/drivers/android/seeds-copies.test.ts","round":"1","fix":"c5867fe877f2e96c9198106ef9726bbae26f40ca"},{"id":"R4","role":"code","class":"testing 3","outcome":"fixed","path":"src/drivers/android/seeds.ts","round":"1","fix":"c5867fe877f2e96c9198106ef9726bbae26f40ca"},{"id":"R5","role":"code","class":"reservation double-counts written bytes","outcome":"nonblocking","path":"src/drivers/android/seeds.ts","round":"1"},{"id":"R6","role":"claims","class":"error message names wrong operation","outcome":"duplicate","canonicalId":"R2","path":"src/drivers/android/seeds.ts","round":"1"}]}Written by an agent. |
V3RON
marked this pull request as ready for review
November 20, 2026 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1750
Status
Implement: done (11/11 green, main merged in d7bb392) Review: fix-check passed twice, 0 open Hardware: n/a Gate: running
Next: gate
Done when
InsufficientDiskSpaceErrorwhen it does not fit, before anything is copied (Seeds.#copyAvd; test "refuses a copy of the seed that does not fit...") —seeds-copies.test.ts10/10 at c5867fe: refusal, exact fit, device-root volume, concurrent copy and failed-copy release; review round 1 + fix-checkDiskSpaceGuard.reserveaction; test insrc/core/driver.test.ts) — asserted indriver.test.tsandseeds-copies.test.ts; baseline copies name their own operation (R2)errors.mdx(both pages) describe the seed-copy refusal. — rows underPROVISION_FAILEDandBASELINE_SAVE_FAILED, checked against the wrapping in leasing andcore/baselines.tsby the fix-checkAssumptions
none
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 3 blocking, 3 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 1. Tokens: 2.1M.
Runs: 10. Cost USD: 3.1477. Agent seconds: 1251.
Rejected:
Assessment: complete
Written by an agent.