Skip to content

fix(android): a seed make's boot timeout names the seed and which boot ran out - #1795

Merged
V3RON merged 4 commits into
mainfrom
bug/1761
Nov 20, 2026
Merged

V3RON merged 4 commits into
mainfrom
bug/1761

Conversation

@V3RON

@V3RON V3RON commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1761

Status

Implement: done (1/1 green) Review: round 1, 0 findings Hardware: n/a Gate: running
Next: gate

Assumptions

none

Review

Spec review: 0 blocking, 0 fixed, 1 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 0.9M.
Runs: 6. Cost USD: 1.5354. Agent seconds: 602.

Assessment: complete

Written by an agent.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 1a58d78c-cc06-4809-89a8-4f2eac5e7b6c
Commits

Reviewing files that changed from the base of the PR and between 63102c9 and e502177.

Files selected for processing: 2

  • src/drivers/android/seeds-copies.test.ts
  • src/drivers/android/seeds.ts

No actionable comments were generated in the recent review.

Walkthrough

The seed startup path now retains the configured boot timeout and wraps BootTimeoutError with the seed ID and boot-stage label. First, second, and snapshot boot paths pass their stage labels to this path. Tests check first- and second-boot timeout messages and update related expectations.

Severity of issue fixed: Low

Merge Risk: Minimal · previous review 63102

Seed-creation boot timeouts now name the seed, the boot that ran out and the configured limit, which makes slow Android lease setup easier to diagnose. The change is small and covered by tests, and no merge-blocking risk was identified.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue #1761 has two expected outcomes. (1) A lease from an empty SIMLOCK_HOME makes the seed and boots within the boot deadline. (2) If a boot times out, the error or daemon log names the slow step. O… Provide the seeds.ts diff for the BootTimeoutError rethrow and the boot-stage labels, so the diagnostic outcome can be confirmed from source. Provide evidence that the empty-home seed make and boots complete within the boot deadline, or sta…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title states the main change: a seed-making boot timeout now names the seed and the boot stage that ran out. The raw summary confirms Seeds now wraps BootTimeoutError with the source ID and boot-s…
Description check Passed The description is brief and written by an agent. It lists status, review counts, and an assessment, and it references issue #1761 with the claim the work is complete. It does not describe the code ch…
Out of Scope Changes check Passed The changes described in the summary stay within the linked issue's scope. src/drivers/android/seeds.ts adds the configured boot timeout and attaches the source ID and boot-stage label to BootTimeoutE…
Full details: Title check

Explanation

The title states the main change: a seed-making boot timeout now names the seed and the boot stage that ran out. The raw summary confirms Seeds now wraps BootTimeoutError with the source ID and boot-stage label for the first, second, and snapshot boots, and the tests check those messages. The title is conventional and specific.

Full details: Description check

Explanation

The description is brief and written by an agent. It lists status, review counts, and an assessment, and it references issue #1761 with the claim the work is complete. It does not describe the code change itself, but it relates to the changeset (the linked issue and the implementation status), so it is not off-topic.

Full details: Out of Scope Changes check

Explanation

The changes described in the summary stay within the linked issue's scope. src/drivers/android/seeds.ts adds the configured boot timeout and attaches the source ID and boot-stage label to BootTimeoutError during seed startup. src/drivers/android/seeds-copies.test.ts updates the affected expectations and adds a test for both boots. Both changes serve the expected outcome that a boot timeout names the slow step. The summary lists no changes to exported declarations. The seeds.ts code itself could not be read, so this verdict relies on the summary and the PR objectives.

Full details: Linked Issues check

Explanation

Issue #1761 has two expected outcomes. (1) A lease from an empty SIMLOCK_HOME makes the seed and boots within the boot deadline. (2) If a boot times out, the error or daemon log names the slow step. Outcome (2) is addressed by the change summary: src/drivers/android/seeds.ts catches BootTimeoutError during seed startup and rethrows it with the source ID and boot-stage label (first boot, second boot, or snapshot boot). src/drivers/android/seeds-copies.test.ts adds a test that checks a timeout in either boot names seed_two and the boot. The summary does not show a change to the timing path or to the root cause of the 470 s boot, and the issue states the cause is unknown. Outcome (1) therefore has no code evidence from this PR. The reviewed diff of seeds.ts could not be read: the repository inspection returned an unavailable result for the changed blob, and the file read was truncated before the new code. The result rests on the change summary. The reviewer note that src/leasing/acquisition-workflow.ts #provision logs nothing on seed-make timeout is unverified; the issue allows the error alone, so the daemon log gap does not by itself fail outcome (2).

Resolution

Provide the seeds.ts diff for the BootTimeoutError rethrow and the boot-stage labels, so the diagnostic outcome can be confirmed from source. Provide evidence that the empty-home seed make and boots complete within the boot deadline, or state that this PR addresses only the diagnostic outcome and that #1761's timing requirement is tracked elsewhere (for example under #1068) so the requirement can be scoped.

Finishing Touches

Fix failing CI checks

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 269188c1-5109-45cd-b607-cfe8a3918721
Commits

Reviewing files that changed from the base of the PR and between ce11fa7 and 63102c9.

Files selected for processing: 2

  • src/drivers/android/seeds-copies.test.ts
  • src/drivers/android/seeds.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

@V3RON

V3RON commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 63102c9

Runs: 6. Cost USD: 1.5354. Agent seconds: 602.
Tokens input 126, output 26810, cache read 2596050, cache write 262876.
- build implementer: claude-sonnet-5-5 127 s $0.2533
- audit implementer: claude-sonnet-5-5 37 s $0.1386
- review 1 reviewer: claude-sonnet-5-5 234 s $0.1871
- review 1 spec: claude-sonnet-5-5 30 s $0.1612
- review 1 code behaviour: claude-opus-5-5 159 s $0.7007
- review 1 claims: claude-sonnet-5-5 15 s $0.0945
Finding outcomes: {}. Classes: {}.
{"findings":[]}

Written by an agent.

@V3RON

V3RON commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Review notes

Not blocking, not verified. Each is one reviewer's claim.

  • spec: src/leasing/acquisition-workflow.ts #provision logs nothing when a seed make times out, so the new message reaches only the lease error, not the daemon log

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review November 20, 2026 07:44
@V3RON
V3RON merged commit c780a49 into main Nov 20, 2026
33 checks passed
@V3RON
V3RON deleted the bug/1761 branch November 20, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: a lease from a home with no seed timed out after 470 s booting (PROVISION_FAILED)

1 participant