fix(ci): generate coverage XML for manager app so TiCS can ingest it#805
Merged
Conversation
The github-runner-manager coverage-report tox env only ran `coverage report` (terminal summary) and never `coverage xml`, so no XML report was produced for the manager app. TiCS scans the workspace for coverage XML and was blocked with nothing to ingest. Add `coverage xml -o coverage/coverage.xml`, matching the root tox.ini.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
coverage xml -o coverage/coverage.xmlto thecoverage-reporttox env ingithub-runner-manager/tox.ini.The TiCS workflow runs coverage for both the charm (root
tox.ini) and the manager app (github-runner-manager/tox.ini). The root env already produced an XML report, but the manager'scoverage-reportenv only rancoverage report(a terminal summary) and never emitted XML.Why we need it
TiCS scans the workspace for a coverage XML report to ingest unit-test coverage. With no XML produced for the manager app, TiCS was blocked. This change makes the manager env emit
coverage/coverage.xml, matching the roottox.inipattern.Verified locally:
tox -e unit,coverage-reportingithub-runner-manager/now writes a valid Cobertura XML report (86% coverage, above thefail_under=73threshold).Checklist
docs/changelog.mdwith user-relevant changes — N/A, no user-facing changeterraform fmtpasses andtflintreports no errors — N/Agithub-runner-manager/pyproject.toml. — N/A, no application code change (tox config only)