feat(version): configurable pr-body - #727
Open
furcan wants to merge 4 commits into
Open
Conversation
|
Author
|
CC: @Andarist Thank you in advance 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
There are some open discussions around it but no outcome or decisions.
Changesets as developer-intent release management tool can be used/in-use broader then only NPM Packages.
if
package.jsonpresent, and SemVer is a preferred version management for any project, this tool (from CLI to Action) can be used.The current PR description with pre-state, max content length etc explicitly targeting NPM and Publishing to an NPM artifactory types of wordings.
Changes
What this PR does is
pr-bodyinput, as following the same naming convention that is picked since v2.{PACKAGES_INFO}special identifier in anywhere they want to use in their custom PR body text.THIS_AND_THAT \n{PACKAGES_INFO}or justWHATEVERAdditional Code Changes
I can revert these if owners/maintainers don't likes
isObjectutil moved fromrun.tstoutils.ts, extended with array checkisStringutil added for newprBodyto allow explicitly onlystringwhen runtimerun.types.tsfile for the touched functions =>getVersionPrBody+runVersionWhats remaining
action