Remove low hanging fruit usages of GithubRandomKeyAuth#404
Open
MoralCode wants to merge 11 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| clones_data = [] | ||
|
|
||
| if clones_data: | ||
| process_clones_data(clones_data, f"{owner}/{repo}: Traffic task", repo_id) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E1120: No value for argument 'logger' in function call (no-value-for-parameter)
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…hat it uses keyman Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…ssing up the tree Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…are not, our regular github API access classes Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…/search Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
force-pushed
the
fix/github-random-key-auth
branch
from
50051df to
786b098
Compare
| try: | ||
| key_auth = GithubRandomKeyAuth(logger) | ||
| grab_committer_list(logger, key_auth, repo_git, tool_source, tool_version, data_source, platform) | ||
| grab_committer_list(logger, None, repo_git, tool_source, tool_version, data_source, platform) |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
E0602: Undefined variable 'grab_committer_list' (undefined-variable)
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GithubRandomKeyAuthis a legacy, deprecated method of retrieving API keys that was replaced by keymanSince GithubDataAccess does nothing with the value passed into it at this position (used to be for the randomkeyauth), we are able to replace any code passing values in with a no-op and follow things up the chain to clear out uses of this that exist already.
Notes for Reviewers
Not yet tested. should probably be tested to full collection to make sure things still work.
Signed commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below:
- What tools were used?
- How were these tools used?
- Did you review these outputs before submitting this PR?