current time along with key expiry time#418
Open
Dipro-cyber wants to merge 1 commit into
Open
Conversation
…keys CLI Adds a 'Current Time' line above the API key table in the 'collectoss github api-keys' command output. This makes it easier to compare key reset times against the current time at a glance. Fixes chaoss#412 Signed-off-by: Diptesh Roy <droy88333@gmail.com>
Contributor
|
the code itself LGTM. Will test this eventually and merge (currently thinking for v1.2 but we'll see) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a "Current Time" line above the API key table in the
collectoss github api-keyscommand output. This makes it easier to compare key reset times against the current time at a glance. Reuses the existingepoch_to_local_time_with_am_pm()helper so the format is consistent with the reset time column.This PR fixes #412
Notes for Reviewers
3-line change in
collectoss/application/cli/github.py. No new dependencies.Signed commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below: