feat: update auth flow#19
Merged
Merged
Conversation
The dev build profile shared keyringService="chatwoot-cli" with prod and
only varied the entry name, but DeleteAPIKey calls DeleteAll(keyringService).
A dev `auth logout` therefore erased the prod login's token (and vice versa),
breaking the separate-credentials guarantee.
Namespace the keyring service per build profile ("chatwoot-cli" for prod,
"chatwoot-cli-dev" for dev) so DeleteAll stays scoped to the active build while
keeping its "wipe stale entries" behavior. The entry name is shared again.
Add build-profile guards (prod/dev) and a logout-isolation regression test, and
derive the legacy-config test path from ConfigPath() so the package passes under
-tags dev too.
`auth login` validated the API token via /api/v1/profile but never checked that the token could access the account ID the user entered. A wrong or mistyped account was saved anyway and only surfaced later as a cryptic 404 on the first account-scoped call. Parse the accounts membership list already returned by the profile endpoint and reject login when the entered account is not among them, naming the accounts the key can access. Instances that return no accounts are left unaffected.
|
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two improvements to
auth loginand how the CLI stores credentials.Separate dev credentials
Dev builds (
go build -tags dev/mise run dev) now use their own config file and keyring, so iterating on the CLI never reads, overwrites, or deletes the credentials of an installed prod binary.~/.chatwoot/config.yaml+ keyring servicechatwoot-cli~/.chatwoot/config.dev.yaml+ keyring servicechatwoot-cli-devThe dev path is gated behind the
devbuild tag and is compiled out of release builds entirely.config viewshows aProfile: devline on dev builds.Verify account access at login
auth loginvalidated the API token but not that it could access the account ID you entered — a wrong/typo'd account was saved anyway and only failed later as a 404 on the first call. Login now checks the account against the profile's membership list and rejects up front, naming the accounts the key can access. Instances that don't return accounts are unaffected.Tests
auth loginintegration testgo test ./...andgo test -tags dev ./...