feat: add ctrl+c cancellation on running pw-checks/tests#1292
Draft
ferrandiaz wants to merge 5 commits intomainfrom
Draft
feat: add ctrl+c cancellation on running pw-checks/tests#1292ferrandiaz wants to merge 5 commits intomainfrom
ferrandiaz wants to merge 5 commits intomainfrom
Conversation
|
🎉 Experimental release successfully published on npm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected Components
Notes for the Reviewer
Adds a
--detach(-d) flag to thetest,pw-test, andtriggercommands. When active, Ctrl+C no longer exits immediately — instead it shows a confirmation prompt and cancels the remote test session viaPOST /v1/cancel, allowing the server to return results marked as cancelled rather than dropping the connection mid-run.SIGINT flow (with
--detach)--detach: Ctrl+C exits immediately (behavior unchanged)Key files changed
rest/cancel.ts— new file, thin client forPOST /v1/cancelabstract-check-runner.ts— SIGINT handler added as private methods; cleanup infinallyisCancelledprioritytest,pw-test,triggercommand files — flag declaration and cancel handler wiring