Repository navigation
Unit testing framework - #254
karandeol-26 wants to merge 4 commits into
Conversation
|
Hi @karandeol-26 , Kelsey mentioned that you would be creating this PR. I'm excited about it. Let me know when it is ready for review. Cheers, |
|
Hi @karandeol-26 , Checking in on this. Is this still something that you're working on? Cheers, |
|
Hi @alex-ozdemir, Yes, still working on it. Sorry for the silence, the semester got busier than I expected. The implementation is done. What’s left is getting CI passing. I’ll have that done and mark this ready for review in a couple days. Cheers, |
8cc05b0 to
bc83e9f
Compare
|
Hi again @alex-ozdemir, this PR is ready for your review. I resolved the CI failure, and all checks are now passing. Apologies for the longer-than-expected turnaround, and thank you for your patience. I’d really appreciate your feedback when you have a chance. |
|
Sounds good! I'll get you a review in the next week or two. |
alex-ozdemir
left a comment
alex-ozdemir
left a comment
There was a problem hiding this comment.
This is a very nice PR. Just a few nits before merging.
There was a problem hiding this comment.
Right now, this module is r1cs-specific, which its name does not suggest. I suggest renaming either the module or the functions within.
There was a problem hiding this comment.
Same comment as for compile.rs.
| proof backend, so a test passes only if the circuit is satisfiable for the given | ||
| inputs. | ||
|
|
||
| **Step 1: Write tests** |
There was a problem hiding this comment.
Nit: I would use ###. Same below.
This draft PR adds a unit-testing framework for ZoKratesCurly using @test annotations. It lets users provide test inputs, check assertions, and run proof generation and verification with Groth16 or Mirage.
The branch includes the framework, tests, and examples.
Opening this as a draft for feedback on the approach and implementation.