Conversation
* fix: address CodeRabbit review findings on the v0.4.12 merge (#499) - Makefile: add pw-lock and secp256k1_multisig_v2 to .PHONY so make all cannot skip their recipes when same-named files or directories exist - README: list the install <tool> command in the Usage block - ckb-debugger-install: tighten legacy-shim detection so only the exact v0.4.x fallback body (shebang + exec offckb debugger) is upgraded; a foreign file that merely mentions offckb debugger is left untouched - proxy-events: isolate per-member failures in the JSON-RPC batch loop so one malformed send_transaction cannot prevent later requests from being recorded; add coverage for a failing member followed by a valid one * fix: address CodeRabbit review on #500 - ckb-debugger-install: classify a legacy v0.4.x fallback shim only when the whole file matches its exact body (CRLF-normalized, one trailing newline ignored); a legacy body with extra user content is left alone - proxy-events: normalize non-Error thrown values (Error.message vs String(error)) before logging so a null/string throw cannot abort the batch loop - tests: near-match legacy shims (Unix/Windows) stay untouched, Windows exact legacy shim upgrades, non-Error and null throws are isolated
…once (fixes #498) (#501) - Make the balance address argument required so `offckb balance` prints `error: missing required argument 'toAddress'` instead of leaking the SDK's `Unknown address format undefined`. - Only emit commander errors through logger.failure in JSON mode; in human mode commander's writeErr already printed the line once, so re-emitting duplicated every commander error on stderr.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (5)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.