security: close telemetry leak in preconnectAnthropicApi startup path#1253
Conversation
🔒 Security Discovery: Un-gated outbound connection bypasses privacy controls
Summary
-------
preconnectAnthropicApi() unconditionally sends a TCP+TLS handshake to
api.anthropic.com on every ccb startup — even when the user has explicitly
disabled all non-essential traffic via CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1
or DISABLE_TELEMETRY=1.
This is the LAST un-gated outbound connection in the entire startup path.
Every other telemetry sink (Sentry, Langfuse, OpenTelemetry, GrowthBook,
1P Event Logger, Datadog, BigQuery, etc.) already respects the
privacyLevel module's isEssentialTrafficOnly() gate. This one did not.
Impact
------
While the preconnect is a HEAD request with no payload, the connection
itself leaks the client's IP address and session timing to Anthropic's
infrastructure. For privacy-conscious users and enterprise deployments
that have disabled telemetry, this constitutes an unexpected data leak.
Fix
---
Add isEssentialTrafficOnly() check at the function entry, consistent
with every other privacy-gated code path in the codebase. The
privacyLevel module is already imported by init.ts and 12+ other
modules — no new dependencies.
Verification
------------
Reproduced and verified via strace on Linux (aarch64):
# Before fix
$ strace -f -e connect ccb -p <<< 'hello'
connect(16, sin_addr=inet_addr("160.79.104.10"), sin_port=htons(443)) = 0
# ↑ connector to api.anthropic.com despite CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1
# After fix
$ strace -f -e connect ccb -p <<< 'hello'
# ↑ zero remote TCP connections — all traffic to localhost only
Changes: 1 file, +5 lines (import + gate)
📝 WalkthroughWalkthroughThe PR adds a privacy-aware guard to the Anthropic API preconnection function. When the application is configured to allow only essential traffic, ChangesEssential Traffic Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/utils/apiPreconnect.ts`:
- Line 28: The import in src/utils/apiPreconnect.ts currently uses a relative
path for isEssentialTrafficOnly; replace the relative import
("./privacyLevel.js") with the project alias form (e.g., import from
'src/utils/privacyLevel' or 'src/utils/privacyLevel.js' depending on codebase
conventions) so it uses the configured src/* mapping; update the import
statement that references isEssentialTrafficOnly accordingly and run a quick
typecheck to ensure the alias resolves.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2c9cda14-c135-491d-b228-88b80eba349c
📒 Files selected for processing (1)
src/utils/apiPreconnect.ts
|
|
||
| import { getOauthConfig } from '../constants/oauth.js' | ||
| import { isEnvTruthy } from './envUtils.js' | ||
| import { isEssentialTrafficOnly } from './privacyLevel.js' |
There was a problem hiding this comment.
Use src/* alias for this new import.
Please switch this new relative import to the configured alias form to match repo rules.
Suggested diff
-import { isEssentialTrafficOnly } from './privacyLevel.js'
+import { isEssentialTrafficOnly } from 'src/utils/privacyLevel.js'As per coding guidelines, "Import paths must use the src/* alias (e.g., import { ... } from 'src/utils/...'); tsconfig maps src/* to ./src/*."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| import { isEssentialTrafficOnly } from './privacyLevel.js' | |
| import { isEssentialTrafficOnly } from 'src/utils/privacyLevel.js' |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/utils/apiPreconnect.ts` at line 28, The import in
src/utils/apiPreconnect.ts currently uses a relative path for
isEssentialTrafficOnly; replace the relative import ("./privacyLevel.js") with
the project alias form (e.g., import from 'src/utils/privacyLevel' or
'src/utils/privacyLevel.js' depending on codebase conventions) so it uses the
configured src/* mapping; update the import statement that references
isEssentialTrafficOnly accordingly and run a quick typecheck to ensure the alias
resolves.
claude-code-best
left a comment
claude-code-best
left a comment
There was a problem hiding this comment.
LGTM. Simple, consistent, and verifiable.
What this does: Adds isEssentialTrafficOnly() gate at preconnectAnthropicApi() entry — the same pattern already used by bootstrap.ts, grove.ts, releaseNotes.ts, and 9 other modules in the codebase.
Why it's correct:
- The preconnect sends a TCP+TLS handshake to
api.anthropic.comon startup. It's a performance optimization (warm the connection pool), not a functional requirement. - When
CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1, users intend zero non-user-requested outbound connections. This was the last un-gated one. - The check is a pure env-var read with no I/O — zero perf impact on the gate itself.
- Placement after the
firedguard is correct: it avoids any module-level side effects if the function is never called.
Verification: Existing tests pass (bun test src/utils/__tests__/privacyLevel.test.ts → 12/12). The typecheck has only the pre-existing bun type-def issue, zero new errors.
2 participants
🔒 Security Discovery: Un-gated outbound connection bypasses privacy controls
Summary
preconnectAnthropicApi() unconditionally sends a TCP+TLS handshake to api.anthropic.com on every ccb startup — even when the user has explicitly disabled all non-essential traffic via CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1 or DISABLE_TELEMETRY=1.
This is the LAST un-gated outbound connection in the entire startup path. Every other telemetry sink (Sentry, Langfuse, OpenTelemetry, GrowthBook, 1P Event Logger, Datadog, BigQuery, etc.) already respects the privacyLevel module's isEssentialTrafficOnly() gate. This one did not.
Impact
While the preconnect is a HEAD request with no payload, the connection itself leaks the client's IP address and session timing to Anthropic's infrastructure. For privacy-conscious users and enterprise deployments that have disabled telemetry, this constitutes an unexpected data leak.
Fix
Add isEssentialTrafficOnly() check at the function entry, consistent with every other privacy-gated code path in the codebase. The privacyLevel module is already imported by init.ts and 12+ other modules — no new dependencies.
Verification
Reproduced and verified via strace on Linux (aarch64):
Before fix
$ strace -f -e connect ccb -p <<< 'hello'
connect(16, sin_addr=inet_addr("160.79.104.10"), sin_port=htons(443)) = 0
↑ connector to api.anthropic.com despite CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1
After fix
$ strace -f -e connect ccb -p <<< 'hello'
↑ zero remote TCP connections — all traffic to localhost only
Changes: 1 file, +5 lines (import + gate)
Summary by CodeRabbit